-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix model crash by adding default pbr material #6906
Conversation
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Fine by me, #6805 should made the release. |
It's looking like #6805 won't make the release so I reopened this PR. |
I'm still not convinced we should rush to get this workaround in for the release since we have the actual fix coming soon. Was this issue a common problem that a number of our users are experiencing? |
Okay, that's significant |
Who should review this? @likangning93? |
I think @ggetz has more familiarity with the gltf-pipeline code and would be better to review this. |
Since |
#6805 completely rebuilds the files in |
Fixes #6891
Like #6857 (comment), this fix is temporary until #6805 is in.